Backport PR #16671 to 8.16: PipelineBusV2 deadlock proofing #16680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* pipeline bus: add deadlock test for unlisten/unregisterSender * pipeline bus: eliminate deadlock Moves the sync-to-notify out of the `AddressStateMapping#mutate`'s effective synchronous block to eliminate a race condition where unlistening to an address and unregistering a sender could deadlock. It is safe to notify an AddressState's attached input without exclusive access to the AddressState, because notifying an input that has since been disconnected is net zero harm. (cherry picked from commit 8af6343)
|
💛 Build succeeded, but was flaky
Failed CI Steps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #16671 to 8.16 branch, original message:
Release notes
What does this PR do?
PipelineBus#unlistenandPipelineBus#unregisterSenderPipelineBusV2Why is it important/What is the impact to the user?
Failing to shut down is not good.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)How to test this PR locally
Related issues